search

saibing / bingo

Bingo is a Go language server that speaks Language Server Protocol.
MIT License
495 stars 25 forks source link

CompletionItem documentation string #91

Closed detvdl closed 5 years ago

detvdl commented 5 years ago

Hello,

I was wondering if it's on the roadmap to add the appropriate documentation strings as an attribute to the CompletionItem struct. Currently company-lsp for emacs uses this information to provide documentation while completion candidates are being shown, which, at least in my personal case, helps quite a bit when exploring a language and/or library.

Currently I have added a crude, hacky version of such functionality in my own fork, but this is very far from idiomatic or correct, as I am only a novice at Go.

If this is not on the roadmap due to the ongoing developments of the official Go lsp server or personal reasons, feel free to close this issue at once.

mbana commented 5 years ago

I've got this implemented but I don't like the way I've done it, @saibing. See this PR: https://github.com/saibing/bingo/pull/130.

Imgur

mbana commented 5 years ago

@detvdl, looks like this PR got merged https://github.com/saibing/bingo/pull/130. Please try now.

detvdl commented 5 years ago

@mbana Sorry for the late reply, tried it out and works as expected, thanks for doing this! 😄 Guess this issue can be closed now @saibing

mbana commented 5 years ago

Please close issue?