saicaca / fuwari

✹A static blog template built with Astro.
https://fuwari.vercel.app
MIT License
1.43k stars 330 forks source link

<style> Tailwind CSS syntax prevents HMR from not working. #195

Closed L4Ph closed 1 month ago

L4Ph commented 2 months ago

The following issue has been resolved. This is a temporary solution, and we are considering further revisions and changes later.

https://github.com/saicaca/fuwari/issues/192

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:42pm
L4Ph commented 2 months ago

The banner image seems to have disappeared, so I'll investigate a bit... 😢

thedevstone commented 2 months ago

The banner image seems to have disappeared, so I'll investigate a bit... 😢

In the PR you commented out the banner?

L4Ph commented 2 months ago
  banner: {
    enable: false,
  }

... but image cannot load. will continue investigating.

L4Ph commented 2 months ago

image 🀔

thedevstone commented 2 months ago

image 🀔

cloned the PR, confirmed that is not working

thedevstone commented 2 months ago

Fixed: Screenshot from 2024-09-27 11-52-29 Cannot push, please @L4Ph fix this according to photo, thanks

thedevstone commented 1 month ago

Please merge the fix cos it's a very frustrating having the HMR not working

thedevstone commented 1 month ago

News on this PR?

saicaca commented 1 month ago

image

@L4Ph I don't know why, but the max-w-none here seems to be overridden. Prepending a ! should solve the problem. !max-w-none

https://github.com/saicaca/fuwari/blob/8beeba81db3a5492aef52b712b47275013c74935/src/components/misc/Markdown.astro#L10

saicaca commented 1 month ago

Let me fix it. Thank you for your contribution.

L4Ph commented 1 month ago

Thanks!