New features for TOC - Githubissues

foxton9 commented 3 weeks ago

Glad to know new toc was released.

As in https://github.com/saicaca/fuwari/pull/103, I'd like to focus solely on adding features rather than the TOC widget itself.

New features for the existing toc

I think the implementation needs further discussion, as I'm not fully satisfied with the current solution.

It seems there will be some updates for the TOC on mobile and its styling, so I haven't tested those cases.

msedge_PT8flRFaeF

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fuwari-yags	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 3:21am

saicaca commented 1 week ago

Thanks a lot for your contribution! The features are great, but there are still some issues.

The logic of isPageReady may need to be revised:

When clicking on a post at the top of the page, the active headings are not set initially since there's no scroll to trigger the scrollend event. When using the mouse wheel, the event won't be fired until the user stops scrolling for the first time.
On top of that, if the post is short enough, some headings might never be marked as active because they never leave or enter the viewport.

saicaca / fuwari