saicone / OneTimePack

Bungeecord and Velocity plugin that reduces duplicated resource pack requests
MIT License
17 stars 2 forks source link

Support bypassing null check #4

Closed nhanledev closed 8 months ago

nhanledev commented 8 months ago

Hello,

I am using ItemsAdder and OneTimePack. On local development, the self-host function of ItemsAdder does not provide hash for the resource pack, so OneTimePack will not work because of invalid packet.

That's why I have to fork OneTimePack to adjust the hash null check to fit my scenario.

I hope there would be a line in the config that allow to bypassing null check, for local development.

Below is the debug info

[15:02:02 INFO]: [HibaraMamoru|/10.0.0.80:50608] <-> ServerConnector [auth0] has connected
[15:02:02 INFO]: [/10.0.0.80:50608|HibaraMamoru] <-> DownstreamBridge <-> [hub0] has disconnected
[15:02:02 INFO]: [HibaraMamoru|/10.0.0.80:50608] <-> ServerConnector [hub0] has connected
[15:02:03 INFO]: [/10.0.0.80:50608|HibaraMamoru] <-> DownstreamBridge <-> [auth0] has disconnected
[15:02:03 INFO] [OneTimePack]: [PLAY] Packet#read() = ClientboundResourcePackPush{url='http://mc.local:10200/generated.zip#51dbcf4ce24c0412b4fa503fc0df4bd501761974', hash='null', forced=true, hasPromptMessage=true, promptMessage='{"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"Hãy bấm chấp nhận để tham gia "}],"text":""}'}
[15:02:03 INFO] [OneTimePack]: Received ResourcePackSend: ClientboundResourcePackPush{url='http://mc.local:10200/generated.zip#51dbcf4ce24c0412b4fa503fc0df4bd501761974', hash='null', forced=true, hasPromptMessage=true, promptMessage='{"extra":[{"text":"\n"},{"bold":false,"italic":false,"underlined":false,"strikethrough":false,"obfuscated":false,"color":"white","text":"Hãy bấm chấp nhận để tham gia "}],"text":""}'}
[15:02:03 INFO] [OneTimePack]: Invalid packet received, so will be cancelled
Rubenicos commented 8 months ago

Just change pack comparator on config, use Comparator: URL in your case.

Rubenicos commented 8 months ago

Also allow invalid pack sending to clients Send-Invalid: true and download the latest version.