search

saiddfhi / gwt-maven

Automatically exported from code.google.com/p/gwt-maven
0 stars 0 forks source link

Look into overriding GWT dependency locations in a more maven centric manner - and GWT jars now in Ibiblio #116

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Ibiblio now contains all the gwt jars and more importantly it has 1.5-RC1.
You can find them at
http://mirrors.ibiblio.org/pub/mirrors/maven2/com/google/gwt/

I was able to move the project I was working on over to 1.5-RC1 utilizing
ibiblio for the required gwt jars. During gwt compliation, gwt-maven
manually injects jars into the project dependency tree. The problem with
this is that the naming convention used is contrary to standard maven
naming practice. The more conventional way to have multiple versions of the
same jar (windows,mac,linux) is to use classifiers as such:

<dependency>
  <groupId>com.google.gwt</groupId>
  <artifactId>gwt-dev</artifactId>
  <version>1.5-RC1</version>
  <classifier>windows</classifier>
</dependency>

The directory structure would then be:
com/google/gwt/
|-gwt-dev/
  '-1.5-RC1/
    |-gwt-dev-1.5-RC1.pom
    '-gwt-dev-1.5-RC1-windows.jar

But even if the subversion structure was correct I think it makes more
sense to provide a option to just completely disable this dependency
injection. The user would then be required to fill in the required jars
inside of the plugin section of the projects pom. This would provide a
escape valve to account for any naming schema and version the user would
require.

Original issue reported on code.google.com by TrashH...@gmail.com on 2 Jun 2008 at 3:59

GoogleCodeExporter commented 9 years ago 
Upon further inspection of the source code the issue was actually completely
unrelated to what I thought. 

The dependency injection is path based. It expects to find the jars in
target/gwtBin/gwt-windows-VERSION/. gwtBin is populated by the dependency of
com.google.com,gwt-windows which is the zip file from the official zip site. The
issue came about because unzipping the RC1 zip created a folder called
gwt-windows-1.5.0 and gwt-maven was expecting it to be gwt-windows-1.5-RC1. It 
then
obviously could not find the dependencies in that folder because it was looking 
in
the wrong place.

Feel free to close this issue.

Original comment by TrashH...@gmail.com on 2 Jun 2008 at 4:54

GoogleCodeExporter commented 9 years ago 
This is still good info, noting that the jars are now in Ibiblio and we might 
be able
to make better use of classifiers. I also sort of like the idea of the override
stuff, would have to investigate and play with that, but it might help us with 
all of
the native dependencies that we do basically have to hard wire.  

I am not gonna close it, but will change it to an enhancement and adjust the 
title.

Original comment by charlie....@gmail.com on 4 Jun 2008 at 11:49

GoogleCodeExporter commented 9 years ago 
Addressed in branch,
http://gwt-maven.googlecode.com/svn/branches/cc_20080814_automaticrefactor/.

Now using the classifier as we should, and using central repo.  Will get merged 
to
trunk soon.

Original comment by charlie....@gmail.com on 15 Aug 2008 at 2:20

GoogleCodeExporter commented 9 years ago

Original comment by charlie....@gmail.com on 15 Aug 2008 at 2:46

GoogleCodeExporter commented 9 years ago 
Fixed as of 2.0-beta22

Original comment by charlie....@gmail.com on 7 Sep 2008 at 10:38