saiddfhi / gwt-maven

Automatically exported from code.google.com/p/gwt-maven
0 stars 0 forks source link

The compiler always compiles even if there are no code changes. #152

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Is this Maven 1 or Maven 2?

Maven 2

What steps will reproduce the problem?
1. With a maven GWT project
2. mvn compile
3. mvn compile

What is the expected output? What do you see instead?

The first time it comiles.  The second time, since nothing has changed it
shouldn't compile.  Instead it does it all over again.  For us this can add
18 minutes to the build.

What version of the product are you using? On what operating system?

2.0-beta23 on Windows XP SP 3.

Please provide any additional information below.

Original issue reported on code.google.com by jon.stra...@gmail.com on 16 Sep 2008 at 7:27

GoogleCodeExporter commented 9 years ago
This is a valid and important issue. I will try to address this when I get a 
chance. 

Will have to research this some to figure out how to add a check to the external
compile script for this (if anybody has ideas/tips, let me know). 

Original comment by charlie....@gmail.com on 17 Sep 2008 at 2:50

GoogleCodeExporter commented 9 years ago

Original comment by charlie....@gmail.com on 17 Sep 2008 at 2:50

GoogleCodeExporter commented 9 years ago
It seems to be an issue of GWT compiler. The first time it compiles .java to 
.class,
then it compiles modules. The second time it compiles modules (.class -> 
javascript)
only.

If you take a look on GWTCompiler.distill()
[http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/src/co
m/google/gwt/dev/GWTCompiler.java?r=3647]
you can see the output directory is ALWAYS cleaned:

Util.recursiveDelete(outDir, true);

regardless if .java/.gwt.xml files were recompiled/modified or not.

I think we could :
a) check if this has been discussed on GWT issue tracker, and post it, if it 
wasn't
b) make the plugin track last-modification-time of all .java and .gwt.xml 
files, and
invoke the script only for modules which were modified...

Original comment by blaszczy...@gmail.com on 24 Sep 2008 at 12:45

GoogleCodeExporter commented 9 years ago
I added an issue to the GWT tracker.

http://code.google.com/p/google-web-toolkit/issues/detail?id=2915

Original comment by jon.stra...@gmail.com on 24 Sep 2008 at 12:57

GoogleCodeExporter commented 9 years ago
Good info here, so leaving it open, but also see 165. 

Original comment by charlie....@gmail.com on 5 Nov 2008 at 9:22

GoogleCodeExporter commented 9 years ago

Original comment by charlie....@gmail.com on 5 Nov 2008 at 9:23

GoogleCodeExporter commented 9 years ago
Closing this to consolidate, on second though, and adding the relative comments 
to
the other issue - 165. 

Original comment by charlie....@gmail.com on 5 Nov 2008 at 9:27