saiddfhi / gwt-maven

Automatically exported from code.google.com/p/gwt-maven
0 stars 0 forks source link

maven 2.1.0 Transitive Dependencies #203

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I Tried to switch to maven 2.1.0 

But the gwt build would fail because Project Transitive Dependencies are
not included in build classpath.

The fix for this problem probably should be in BuildClasspathUtil like this:
troject.getCompileArtifacts()
instead of 
project.getCompileClasspathElements()

Environment
 WinXP, Java 1.6, GWT 1.5.3

PS
 The goal was to use <phase>prepare-package</phase> new in 2.1 for compile
so that application build with site will not require recompilation. 

Original issue reported on code.google.com by skarzhev...@gmail.com on 30 Mar 2009 at 5:36

GoogleCodeExporter commented 9 years ago
I added this approach all over BuildClasspathUtil:

for (Artifact a : (Collection<Artifact>) project.getCompileArtifacts()) {
            items.add(a.getFile());
        }

I am not sure what the exact difference there is to be honest, but it still 
works
fine in all of my tests, and is definitely a cleaner approach. If you say it 
resolves
the transitive deps issues (or should) then I will take your word for it - it's 
on
you if it causes havoc ;). I will do some more testing to make sure all my 
projects
still work, etc, but so far so good with this change. 

Guess I *could* also try Maven 2.1.0, hmmmm.  

Original comment by charlie....@gmail.com on 31 Mar 2009 at 7:24

GoogleCodeExporter commented 9 years ago

Original comment by charlie....@gmail.com on 31 Mar 2009 at 7:24

GoogleCodeExporter commented 9 years ago
Tried several local apps, and simplesample and simpledatasample from the 
project with
2.0.9, and then 2.1.0, after said changes all seems well. 

Thanks for the heads up, please try out the 2.0-RC1 release when it drops any 
day now
(or build from trunk). 

Also note we now support -Dgoogle.webtoolkit.compileSkip too - might fit your 
bill also. 

Original comment by charlie....@gmail.com on 1 Apr 2009 at 12:41

GoogleCodeExporter commented 9 years ago
In 2.0-RC1. 

Original comment by charlie....@gmail.com on 3 Apr 2009 at 1:16