search

saidsay-so / pjdfstest

File system test suite.
https://saidsay-so.github.io/pjdfstest/
Other
8 stars 1 forks source link

feat(tests): replace file flag conditions by guards #113

Closed saidsay-so closed 2 years ago

saidsay-so commented 2 years ago

Guards are functions which test if a requirement is met and returns an error to skip the test if it isn't. This would allow skipping tests which needs capabilities, for example (https://github.com/musikid/pjdfstest/pull/110#issuecomment-1250312411).

asomers commented 2 years ago

The idea is good I think. But what is the connection to FileFlags? There aren't any guards defined that involve FileFlags.

saidsay-so commented 2 years ago

I wanted to replace them with guards because keeping both would be more complicated. File flags conditions aren't really used a lot and can be easily replaced by a guard which tests the required flags.