saif-ellafi / foundryvtt-window-controls

Module for FoundryVTT. Organizes minimized windows on a fixed taskbar. Adds also Maximize and Pin window functionality.
MIT License
6 stars 3 forks source link

PF2e bug/incompatability #42

Open CrackJackFlood opened 11 months ago

CrackJackFlood commented 11 months ago

In the latest release of PF2e system you can do weapon popouts image

These new popouts loose their ability to the close them easily with the x when this module is enabled

Rencos1 commented 3 months ago

I don't know if you found a way to fix this issue but I have the same problem with another system, Advanced 5e (A5E). To fix the issue, I removed the 2 following lines in the function initHooks in windowcontrols.js. This hack is useless now for D&D5e. The "close" label after the "x" icons do not longer appears in the character sheet after they changed the style.

if (this.constructor.name === 'QuestTracker' || (game.modules.get('one-journal')?.active && this.constructor.name === 'JournalSheet') || this.constructor.name === 'ee') // yes, ee is Simple Calendar return result; //const close = result.find(b => b.class === 'close'); //close.label = ''; const newButtons = []; const minimizeSetting = game.settings.get('window-controls', 'minimizeButton');