Closed lucavd closed 1 year ago
Hi @lucavd, it seems you are using a docker container from the old unstable repo SAIGE instead of this repo, which has the stable release chain.
Previously, as per https://github.com/weizhouUMICH/SAIGE/blob/a41727267cb5f843a4446e4d4809cafc72687a5d/extdata/step2_SPAtests.R#L19 there was no support in step 2 for plink files as input files. That support now exists in the current stable release.
Until you update your container to the stable version, you will continue to get that issue.
I suggest you check out #100 which is my PR with docker updates, or you can create a new container from the repo as is.
Good luck!
Thank you @kscott-1
I'm kind of aware of it since this is the docker image of the SAIGE-GATE (last version of the image 0.45) and I noticed that it was an old version of step two.
Do you recommend to transform them in another format prior to step 2?
L
If you are set on using your current docker set up, I would convert your input files to vcfs. I wouldn't recommend that though, since it appears lots of updates have happened to SAIGE since 0.45. I can't speak too much on that since I'm not the developer or the maintainer (@weizhouUMICH), but the best choice (I assume) would be updating your container to 1.x and using your input files as is.
@kscott-1 @weizhouUMICH @weizhou0
I opened a cross issue in GATE. https://github.com/weizhou0/GATE/issues/22
I tried to use step_1 in GATE:0.45 (works) and step_2 in SAIGE:1.2.0 since it should be the same as in GATE but with no luck.
I don't understand (sorry, my bad) the rationale of asking plink files in step1 but other format in step2 that depends from step1 (even in the SAIGE former version)
It's unlikely you'll be using the same input files in step 1 and step 2. Step 1 is fitting a Null GLMM and requires a low number of independent (pruned) variants. Step 2 is for the actual association analysis, which is likely to be a much larger file.
Thank you! I got it working by converting the plink files to vcf and its index file but your reply got me a doubt on how I calculated the step_1. Probably is a naive question but for the NULL model, should I randomly select patients/chromosome/variants as indicated as optional here also for binary traits?
i.e., I don't have to use the plink files with the full dataset in step1 but only a randomly selected subset, correct? If yes, how do you suggest to do it?
PS: I promise that when all works I'll make a foolproof wiki and give it to you...
I'd suggest taking a look at this issue https://github.com/weizhouUMICH/SAIGE/issues/92 from a while back. I hope that gives you the answer you're looking for.
Hello @kscott-1 , I'm trying to use plink files for STEP2 and saw your note about this being possible in the stable version of SAIGE.
"Hi @lucavd, it seems you are using a docker container from the old unstable repo SAIGE instead of this repo, which has the stable release chain."
I opened the step2_SPAtests.R file and there is no reference to plink files. Please correct me if I completely missed something. I hope that's true.
Hello @kscott-1 , I'm trying to use plink files for STEP2 and saw your note about this being possible in the stable version of SAIGE.
"Hi @lucavd, it seems you are using a docker container from the old unstable repo SAIGE instead of this repo, which has the stable release chain."
I opened the step2_SPAtests.R file and there is no reference to plink files. Please correct me if I completely missed something. I hope that's true.
The files in this repo (saigegit) are updated and stable. You have linked the files from the old unstable repo as well.
You are looking for this file: step2_SPAtests.R
Thank you @kscott-1 I see it now! (I also opened a new issue on this I will close it with what you said).
Hi, I've seen this issue posted in the former repo with no reply. Here's my code and error. Any idea how to solve it? Tha same path for step1 is working fine. Thank you