search

saigegit / SAIGE

Development for SAIGE and SAIGE-GENE(+)
GNU General Public License v3.0
66 stars 29 forks source link

Fix build in Conda: reorder includes to Rcpp* is after savvy #18

Closed pettyalex closed 2 years ago

pettyalex commented 2 years ago

Reorder includes so that RcppArmadillo is last. This allows savvy to build, which cannot build if it is imported after RcppArmadillo.h

This fixes https://github.com/saigegit/SAIGE/issues/17, and is the workaround that I'm using to build this inside of our conda environment.

I don't know what style you want includes in, but I'd be glad to update this to match any preferred include style.

pettyalex commented 2 years ago

Hmm. this doesn't feel like the right approach. Maintaining include order will be impractical without automated tests that would catch this potential problem.

I'm going to look at modifying the Makevars instead.