search

saiintbrisson / command-framework

A lightweight and simple to use command library for Bukkit and Bungee platforms.
Apache License 2.0
55 stars 13 forks source link

command aliases are not being registered in the first registration of the parent command #25

Closed luiz-otavio closed 1 year ago

luiz-otavio commented 1 year ago

The code below the source-code calls for the register method of the CommandMap due to fixing the correct position of the root command. https://github.com/saiintbrisson/command-framework/blob/ad6ed18e914f7cf1f2ae2c9ef0d0e3f7e2d39f31/bukkit/src/main/java/me/saiintbrisson/bukkit/command/BukkitFrame.java#L145

However, instead of fixing the correct position of the root command, it just allows the aliases to not work, as the default implementation of BukkitCommand doesn't include the correct command aliases of CommandInfo, so it's empty when it should be registered from CommandMap: image

luiz-otavio commented 1 year ago

Should be fixed with the 1.4.0-rc.1 version: https://github.com/saiintbrisson/command-framework/pull/27

luiz-otavio commented 1 year ago

Also, it's not based on the rewrite version, so it's entirely dedicated to work after 1.3.0 tag.