search

saik0 / humblebundle-python

An unofficial library for querying Humble Bundle
MIT License
69 stars 15 forks source link

Order List now returns GameKey object #4

Closed yamatt closed 10 years ago

yamatt commented 10 years ago

So this is one alternative. It could also just return a string, but then a decision needs to be made about how client.order method is called. Should it accept a string? A GameKey object? Both?

saik0 commented 10 years ago

a decision needs to be made about how client.order method is called. Should it accept a string? A GameKey object? Both?

Good point, lets move discussion to #5. I'm closing this PR, it has old history and doesn't really fix the problem.