Closed klingac closed 4 years ago
Thanks for the PR! I will have to look at this more deeply, Change in package might break few things (edge cases) Right now based on some situations I’m not able to review , it will take some time for me.
In between this if some collaborator can review or merge will be great!
Hi @klingac ,i have just now verified. and sorry for the late. it all looks good just that there are few more changes needed. which i will be doing. instead merging this i will do the changes in my end, along with other changes.
Thank you for the time you spent to raise this. once done i will ping in the issue linked. closing it for now.
This pull request fixes #54 . Method
initModule()
is called asynchrounously and when we callserver.listen(port, host);
varshost
andport
are undefined. MethodinitModule()
has callback as second param, where we can putserver.listen()
. Another problem is, thatinitModule()
in@pm2/io
package has issue keymetrics/pm2-io-apm#260 that it is not loading module configuration. So i replace@pm2/io
forpmx
package. Pakcagepmx
is deprecated, but is working and is still used by keymetrics in e.gpm2-logrotate
module.Thanks for merging