Closed ghost closed 1 year ago
Hey @jpiar,
Thanks so much for doing this. I will review this property ASAP -one thing I would say is, I'd prefer to use Yarn to keep consistency with the existing setup.
Hey @saikojosh, No problem. Thank you for merging it in. I`ll change it to yarn right away.
In fact, Ive run yarn install but I wonder whether it wouldn
t be beneficial to keep npm as well as this package can be found on npm.
Also because my project uses npm.)
also, fyi Ive created a new npm package with a "-temp" suffix. This is a temporary solution for my project and I
ll remove it once this issue is solved.
I hope that`s ok with you?
OK I’ll have a play around before I merge it in.
On 12 Jul 2017, at 17:42, dzuray notifications@github.com wrote:
@jpiar commented on this pull request.
In package.json https://github.com/saikojosh/Object-Assign-Deep/pull/6#discussion_r127007986:
@@ -20,7 +24,7 @@ "object", "array" ],
- "main": "objectAssignDeep.js",
- "main": "bin/objectAssignDeep.js", This works for es6, but es5 doesn`t seem to like that for some reason.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/saikojosh/Object-Assign-Deep/pull/6#discussion_r127007986, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvie9OBLO1yykDGx7hFgXTubxVTntnQks5sNPeQgaJpZM4OVhLM.
@saikojosh if possible, can you merge this in? I've had to strip out this package from my repo as it breaks our build scripts.
I've converted the module to single quotes. When I've got more time I'll take a proper look at this. Right now, it feels a bit overkill.
In response to Please run Babel or similar for dist #4 issue. (I`m also using this lib in my own project)