search

saikyun / freja

Self-modifiable editor for coding graphical things
68 stars 3 forks source link

Behavior when search fails and/or reaches the end of source #2

Closed sogaiu closed 3 years ago

sogaiu commented 3 years ago

May be if a search fails there could be some kind of feedback.

Also, if a search has "reached the end of source", perhaps similar feedback could be given and/or the search could wrap.

Just some ideas.

saikyun commented 3 years ago

With commit the search does wrap: https://github.com/saikyun/freja/commit/e89face5c0a4cc0f1e5b6aa5f73a8f058824cc16

Need to consider failed search. Maybe the search bar could just show nof matches and which one you're currently on.

sogaiu commented 3 years ago

Seems to be working :+1:

saikyun commented 3 years ago

Now it shows which match you're at with: https://github.com/saikyun/freja/commit/2d02c05651a061af38acfa0378eb49cebd95d67f

saikyun commented 3 years ago

Accidentally pushed buggy code, should be fixed in: https://github.com/saikyun/freja/commit/50efbc4080125b4effee17ef55f37dc538ae80ae