Closed exodus454 closed 4 years ago
Thanks! Ill double check later, would you like to be added as a collaborator to the main repository. As stated, looking to hand it off (you can transfer ownership), but get some more involved. Having 5+ forks is only going to confuse people.
Sorry I thought I accepted your invitation. I've never used github to contribute so I’m trying to figure it out. I can just make changes against the repo without a pull request for each, right?
Also I was going through a few of the definitions just to see where they’re at, there’s a lot missing! Some of them are pretty much blank with no translations. The CSL ones don’t have any of the CSL specific tables defined. I have a few of the V6 defs which I’ve been working off of, I’m just hesitant to upload them without stepping on toes.
I’m happy to help fill in the blanks though
On Fri, Aug 9, 2019 at 1:35 AM saildot4k notifications@github.com wrote:
Thanks! Ill double check later, would you like to be added as a collaborator to the main repository. As stated, looking to hand it off (you can transfer ownership), but get some more involved. Having 5+ forks is only going to confuse people.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saildot4k/MSS54-XDFs/pull/8?email_source=notifications&email_token=AAR7WPOZSXH7A6AAUEKAGGDQDT62TA5CNFSM4IKQDAF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35USDI#issuecomment-519784717, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR7WPL3KZIFRMQCIJEAM2LQDT62TANCNFSM4IKQDAFQ .
-- Dan Stearns Exodus454@gmail.com 203-417-0740 -- Dan Stearns Exodus454@gmail.com 203-417-0740
The point of the project was to be open. One of the orig 3 gifted this to me to be shared. TAP and Paffy are long gone, might as well keep the spirit of this alive. I would say lets upload your newer ones. No one was flustered by these being re-released, I kept Taps documentation as well regarding potential consequences as you can see in the first readme.md.
If you join as a collaborator, it can sync this and your github folder on your computer, any changes you push to the repository like I have. There are ways to sync partial files too, IE I fix and offset in v2101, and you correct something else: if you use github correctly, you can choose which info gets pushed, especially easy if you use github desktop.
Ok, I do agree. I've been leaning towards uploading them anyway. I'l dig out my unmodified originals and upload them this evening.
I have it setup in github desktop right now, it's much easier to use than the command line (especially since I'm not used to it yet). How religious should I be with the commits?
On Fri, Aug 9, 2019 at 11:05 AM saildot4k notifications@github.com wrote:
The point of the project was to be open. One of the orig 3 gifted this to me to be shared. TAP and Paffy are long gone, might as well keep the spirit of this alive. I would say lets upload your newer ones. No one was flustered by these being re-released, I kept Taps documentation as well regarding potential consequences as you can see in the first readme.md.
If you join as a collaborator, it can sync this and your github folder on your computer, any changes you push to the repository like I have. There are ways to sync partial files too, IE I fix and offset in v2101, and you correct something else: if you use github correctly, you can choose which info gets pushed, especially easy if you use github desktop.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saildot4k/MSS54-XDFs/pull/8?email_source=notifications&email_token=AAR7WPK7ONXHQ2BN5ASL2TLQDWBSNA5CNFSM4IKQDAF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD36555I#issuecomment-519954165, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR7WPIQDNMWVL2JTY55CL3QDWBSNANCNFSM4IKQDAFQ .
-- Dan Stearns Exodus454@gmail.com 203-417-0740
If you would like, push them to a folder within the orig unmodified branch: Original-XDFs-from-FindRoutine, say in a V5 folder. From there we can compare/contrast and move over if deemed best.
added what I have to original branch, they're V5 and the CSL is V6
On Sat, Aug 10, 2019 at 8:05 PM saildot4k notifications@github.com wrote:
If you would like, push them to a folder within the orig unmodified branch: Original-XDFs-from-FindRoutine, say in a V5 folder. From there we can compare/contrast and move over if deemed best.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saildot4k/MSS54-XDFs/pull/8?email_source=notifications&email_token=AAR7WPNRXCZ3JMGQVMCHT3DQD5JSZA5CNFSM4IKQDAF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AXIVY#issuecomment-520189015, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR7WPKRFD3X2TK226D65BLQD5JSZANCNFSM4IKQDAFQ .
-- Dan Stearns Exodus454@gmail.com 203-417-0740
So I looked at the V5 folder you created, and interestingly, the files I uploaded are V5 with search script .35, which are almost all labeled the same internally. There are some differences with the v5 you uploaded, and a little more data. I would like to compare a little more before moving to the master branch. A concern I have is making sure all xdfs have the same conversions IE the V5 you uploaded has some values in AFR 14.6 base vs Lambda, and for any directions we post in the wiki should reference the same conversions to avoid confusion or worse, harm to the engine. I won't be taking too much of a look for the next 2 weeks as I am preparing for then on vacation.
I recall seeing the same thing when I looked at them, it almost seemed to me like a rushed/work in progress release to me. It's also interesting how the file names are V5/V4, not just V5. I think having consistent conversions is a must. That's one thing that's always made these difficult to use and trust. Personally I always stick to lambda where I can or AFR 14.2. This ECU doesn't seem to handle anything naively in AFR so it just adds another layer of complexity. But yes I agree it should all be clearly laid out in the wiki.
Enjoy your vacation!
So we added ChrisDeBmw, maybe we open up some of this for another topic on M3 Forum as it seems to be one of the few places with participation. Don't want to get burned or sidetracked either. Staying here may keep it to more advanced users capable with TunerPro and combing through hex. You stated you have a few of the V6 files? I see one. Any more? Noted in the Collaborators Wanted issue that I would be willing to pony up $100 for the E Power Framwork if we can find it. (found some sources, but do we trust random pay for sites?
If you create a new thread on M3Forum, can you please write one of the admins to have a look at my account "chris_de".. i cant do anything in this board, my account is locked for some reason :-1:
I can’t find your account. Just create a new one.
On Aug 13, 2019, at 7:51 AM, ChrisDeBmw notifications@github.com wrote:
If you create a new thread on M3Forum, can you please write one of the admins to have a look at my account "chris_de".. i cant do anything in this board, my account is locked for some reason 👎
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/saildot4k/MSS54-XDFs/pull/8?email_source=notifications&email_token=AK6D5S5AB2GXO2DDGGI4TNTQELC6PA5CNFSM4IKQDAF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4F5D4I#issuecomment-520868337, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6D5S3RDUA47G33X4YEM2LQELC6PANCNFSM4IKQDAFQ.
wrong locations fixed against J484 bin
displaying correctly now