search

sailfish-keyboard / sailfishos-presage-predictor

Presage based input predictor for the Sailfish OS
https://openrepos.net/content/sailfishkeyboard/maliit-plugin-presage
GNU General Public License v3.0
7 stars 4 forks source link

Performance degradation on 4.2.0.21 #33

Closed rinigus closed 2 years ago

rinigus commented 2 years ago

With the reflash using 4.2.0.21, I have seen rather poor predictions by the keyboard. Not sure what is going on, will have to check the logs and installed packages. Could be also some issue with my setup. Recording as an issue here to keep track.

Lang: en_US Packages installed from Chum and OpenRepos

martonmiklos commented 2 years ago

I just realised this for hu_HU so looks to be not locale dependant. HW: XA2

rinigus commented 2 years ago

Looking into it. Have to remember how we made it all happen first :)

rinigus commented 2 years ago

Issue is in language code setting:

    PresagePredictor {
        id: thread
        // note: also china language codes being set with this, assume xt9 model just ignores such
        language: layoutRow.layout ? layoutRow.layout.languageCode : ""

There is no layoutRow anymore in SFOS 4.2. So, we need new way to set language code.

/cc @pvuorela

rinigus commented 2 years ago

Don't know whether it is a perfect and expected solution for SFOS 4.2 - submitted PR for review #34.