search

sailfish-keyboard / sailfishos-presage-predictor

Presage based input predictor for the Sailfish OS
https://openrepos.net/content/sailfishkeyboard/maliit-plugin-presage
GNU General Public License v3.0
7 stars 4 forks source link

English keyboard #4

Closed rinigus closed 6 years ago

rinigus commented 6 years ago

I, and I suspect many others, are not that fluent in Hungarian. To expose your work, would you mind to release English keyboard and the corresponding dictionary as well?

rinigus commented 6 years ago

I will look into how to make it possible without breaking things on desktop :) . Thanks for pushing your changes, would be great to make all in sync. Would have to read your code and see where the database changes are applied. We will need to add support for user-learning DB as well, so I can approach it as one bigger task.

If you can push it all during a 8 hours, that will be fine. I'll start working on it in the evening.

martonmiklos commented 6 years ago

And here we go: https://sourceforge.net/u/martonmiklos/presage/ci/added_qtcreator_pro_file/tree/ This adds a pro file for the QtCreator And: https://sourceforge.net/u/martonmiklos/presage/ci/force_clocale_for_numeric_parsing/tree/

This one sets the locale to C for the numeric operations. The XML contains numbers which using . (dot) as decimal separators. Some users reported problems because of different locales. It might be enough to add this to the XML parsing section, but I used this no-brainer approach.

I do not have any other useful additions to presage other than this two.

martonmiklos commented 6 years ago

We will need to add support for user-learning DB as well, so I can approach it as one bigger task.

The current installation should enable it with the UserSmoothedNgramPredictor if I understand correctly what you mean.

rinigus commented 6 years ago

excellent! would you mind also to push the last version of sailfishos-presage-predictor, as in https://github.com/martonmiklos/sailfishos-presage-predictor/issues/10 . That would allow me to test things on device as well.

rinigus commented 6 years ago

Re UserSmoothedNgramPredictor: yes. And we need to make that access different databases depending on language to avoid mixing words from different languages

rinigus commented 6 years ago

PS: I was mainly referring to https://github.com/martonmiklos/sailfishos-presage-predictor/issues/7 . This is on SFOS plugin part and its interaction with presage library

rinigus commented 6 years ago

Closing as a part of bookkeeping. We have English keyboard thanks to @ljo :)