search

sailfishos-applications / filecase

File manager for SailfishOS
Other
9 stars 4 forks source link

Fix action build script to make automatic new download able releases #23

Closed ruditimmermans closed 2 years ago

ruditimmermans commented 2 years ago
  1. Fix action build script to make automatic new downloadable releases
  2. Fix into .spec file the version number to build the correct version number into armv7hl builds
  3. Change my new Github name into about screen
  4. Fix the correct path to show the SD-Card
  5. Update version number to 0.4-2
  6. Remove not needed files of old build script
Olf0 commented 2 years ago

Hi Rudi, I made some small changes; thank you for leaving "allow commits from maintainers" on, so I was able to do that. For details, see my notes there.

This is looking good, although I have not tested it. But I assume you have tested the generated RPM, right?

As noted in my last comment at issue 16, please try to cover a single topic per PR, so all the commits for "Fix show SD-Card" (0ed2aaa, 572e3ef, 5d2f25b, 9c693fe, 3c35644, aa1e173 and my 5e084f2) should have been placed into a separate PR. Never mind, this is O.K. for now, and I also regularly forget to clearly separate different topics into different PRs.

BTW, because I was too lazy to check thoroughly if the filecase.yaml file is really used for generating the spec file, I applied all changes in both, as you did. But we should really determine if that is the case and then either delete filecase.yaml or leave the spec file untouched (because it is auto-generated). Actually I believe that filecase.yaml is unused and can be deleted (plus the corresponding note in the spec file), but would be glad if you check my suspicion.

Because this PR consists of a long commit series with much forth and back, please perform a squash merge (called "Squash and merge" here in the web-frontend, selectable by the down-arrow) of this PR #23, or do you prefer that I am doing this?

P.S.: And please re-view the final result before squash-merging, I may have introduced typos or other nonsense by my commits.

ruditimmermans commented 2 years ago

Hi Olf0, Yes i have tested the automatic builds in my repo it is working as of this speperate PR's would be comming as i was doing everything on my repo webfront i guess.... please make shure you dont delete bad-style.py into the scripts file becoss then it would not build anymore, and alsi the bad-style.xml should not be removed. Yes please make this Squash and merge. Thanks!

Greetings, Rudi

Olf0 commented 2 years ago

Yes i have tested the automatic builds in my repo

Thank you for confirming.

please make shure you dont delete bad-style.py into the scripts file becoss then it would not build anymore,

But your PR 24 was removing bad-style.py, too?!? That is the reason why it is already removed in your master branch, AFAICS.

and alsi the bad-style.xml should not be removed.

It is still there, I did not touch it.

Yes please make this Squash and merge.

O.K., I will, when we have the bad-style-questions sorted out.

ruditimmermans commented 2 years ago

I have add it back yesterday there should be also a PR of that, and what i have see now on the lasted pr what was merged with my repo the bad-style.py was removed with this pr #fa87c43 on my repo i just have note this.

Olf0 commented 2 years ago

I have add it back yesterday there should be also a PR of that

No, there wasn't any.

and what i have see now on the lasted pr what was merged with my repo the bad-style.py was removed with this pr #fa87c43 on my repo i just have note this.

Commit fa87c43 was performed by me. O.K., I will add it back, although I cannot see, where it is still used.

ruditimmermans commented 2 years ago

Oh that's wierd, it would be used by the remove of the build before it makes a new one into the build script what i use there. I try removed yesterday and then it was not building anymore on my repo after i have add it back it was building again....