sailfishos-applications / filecase

File manager for SailfishOS
Other
9 stars 4 forks source link

Remove not needed files of old build script #24

Closed ruditimmermans closed 2 years ago

Olf0 commented 2 years ago

When I reviewed PR #23, I noticed that this file was empty and unused, so I deleted it there (in PR #23) by commit fa87c43. Thus closing this PR #24 un-merged.

ruditimmermans commented 2 years ago

I think you need to remove manual first the build as i dont make a new release i just have see here, it reports : 🌶 failed to delete release with id "59977774" <- Resource not accessible by integration 🌶 failed to delete ref "refs/tags/master" <- Resource not accessible by integration

Mebay something wrong into cepri his repo settings...?

Olf0 commented 2 years ago

I think you need to remove manual first the build as i dont make a new release i just have see here, it reports : hot_pepper failed to delete release with id "59977774" <- Resource not accessible by integration hot_pepper failed to delete ref "refs/tags/master" <- Resource not accessible by integration

Mebay something wrong into cepri his repo settings...?

No, what is wrong is https://github.com/CepiPerez/filecase-sailfish/blame/master/.github/workflows/SailfishFilecaseBuild.yml#L54 There is no tag called master, only a branch called so.

Olf0 commented 2 years ago

@ruditimmermans, what are you trying to achieve by https://github.com/CepiPerez/filecase-sailfish/blame/master/.github/workflows/SailfishFilecaseBuild.yml#L51-L56 ?

Olf0 commented 2 years ago

And now it created a tag and release named master: https://github.com/CepiPerez/filecase-sailfish/releases/tag/master

Well, you may tray to enhance the build script and check if at least the armv7hl RPM attached to the "master"-release works correctly.

I will try to fix up the releases section manually, later.