search

sailfishos-applications / filecase

File manager for SailfishOS
Other
8 stars 4 forks source link

[Bug] Remaining hardcoded paths to `/home/nemo` #67

Open Olf0 opened 5 months ago

Olf0 commented 5 months ago

Still a couple of hardcoded paths to /home/nemo remain in src/megacli.cpp, see https://github.com/search?q=repo%3Asailfishos-applications%2Ffilecase+%22/nemo%22&type=code This also explains, why /home/nemo/.config/cepiperez/… is still used.

Check, if using the folder variable is feasible, as set in src/browser.cpp?

Olf0 commented 5 months ago

A PR addressing this should adhere to the paths chosen for FileCase's "sister app" FlowPlayer, see FlowPlayer's issue #50 and PR #51.

Actually, the code in FlowPlayer's PR#51 is much more elegant than the quick&dirty solution introduced by commit 7369833 almost three years ago, hence FileCase might adopt FlowPlayers's recent code.

P.S.: See also FileCase's PR #46 (merged) and FlowPlayer's commit f3e8492.