Closed ruditimmermans closed 5 months ago
@ruditimmermans, thank you for your contribution. Two comments on why I changed this PR to draft status:
devel
(also called "tip", i.e. the current development code), hence you need to apply your changes atop the current state of devel
and direct your PRs to devel
. I tried to rectify this by changing the base branch to devel
, but this does not work, because you applied your changes atop the current state of the master
branch (if I would stubbornly merge this, it would create a circular commit chain, which git
does not handle well at all).I am not sure that the changes are required in filecase.pro
:
i18n_files.files = translations
i18n_files.path = /usr/share/$$TARGET
INSTALLS += i18n_files
I will try to check, but AFAICS this change you suggested changes just set the default values explicitly.
After some testing I am sure that this is nonsense (as suspected above), because the error message has always been (but nobody looked at it):
[ 228s] lupdate: could not exec '/usr/lib/qt5/bin/lupdate': No such file or directory
[ 228s] lrelease: could not exec '/usr/lib/qt5/bin/lrelease': No such file or directory
Fix the translation file got into the correct place, also update the version into the specs and filecase.qml, i have compile this with the sdk and translations would be there...