sailfishos-applications / filecase

File manager for SailfishOS
Other
9 stars 4 forks source link

[ToDo] Deduplicate icons #75

Open Olf0 opened 7 months ago

Olf0 commented 7 months ago

rpmlint as employed by the Sailfish-OBS criticises (just warnings, no errors):

RPMLINT report:
===============
filecase.i486: W: files-duplicate /usr/share/filecase/icons/filecase.png /usr/share/icons/hicolor/86x86/apps/filecase.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/exec.png /usr/share/filecase/icons/setting.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/document.png /usr/share/filecase/icons/txt.png

filecase.i486: W: files-duplicate /usr/share/filecase/icons/skydrive.png /usr/share/filecase/icons/sky.png

I assume the first one may be unavoidable and likely produced by qmake, which is instructed to copy the source directory icons to $buildroot/usr/share/filecase/, but also (where?) to copy the app icon to /usr/share/icons/hicolor/86x86/apps/. The only thing one may check in the source tree is, if /usr/share/filecase/icons/filecase.png is directly used; still I have no idea where to put it in the first place, if it only needs to be copied to /usr/share/icons/hicolor/86x86/apps/.

The latter three are "real duplicates" and may be substituted by symbolic links, but supposedly the real resolution is to only use one of the two names throughout FileCase's source tree. Although I am not sure, if one of each in the pairs exec.png / setting.png and document.png / txt.png is meant as a placeholder for a better suited icon (i.e. better depicting what it stands for): Only to look up the places at which these icon pairs are used will tell for sure.