sailfishos-applications / flowplayer

Music Player for SailfishOS
https://openrepos.net/content/olf/flowplayer
Other
6 stars 7 forks source link

[Bug] Remaining hardcoded paths to `/home/nemo` and `.config/cepiperez` #101

Closed Olf0 closed 5 months ago

Olf0 commented 5 months ago

Oh, how I hate to revive this topic again, because I assumed it to be dealt with in #20, #47 and #50 (rsp. in the corresponding PRs #21, #48 and #51). But issue #99 made me consider this again, so I used GH code search in hope to exclude this as a reason; though "hope dies last", it ultimately often does:

Another code search for /home/nemo/

The first two hits in also made me search for .config/cepiperez/: Luckily that does not reveal additional hits.

TL;DR

Ultimately only the two hits in src/playlist.cpp (line 264 and line 355) should be rectified and a decision be met WRT the function startMafw: {Go|Stay} (see #104 for "Go")

dcaliste commented 5 months ago

The matchs in src/playlist.cpp are within commented parts of the code, so unused. As for the function startMafw() in utils.cpp. The full function is a no-op.

The last match is in the Lockscreen.qml file, which is completely unused at the moment.

So all these matches have no consequenses. For peace of mind, and in case these parts of the code may become uncommented, it could be ok to adapt these parts also. Or remove them since they are not used.

Olf0 commented 5 months ago

For peace of mind, and in case these parts of the code may become uncommented, it could be ok to adapt these parts also.

Did that by PR #107, because it it less about "peace of mind" than "forgetting and then stumbling over it again and again" and "expecting others who have not seen this discussion to wonder, too".