sailfishos-chum / sailfishos-chum-gui

GUI application for utilising the SailfishOS:Chum community repository
https://openrepos.net/content/olf/sailfishoschum-gui-installer
MIT License
13 stars 17 forks source link

Continue to overhaul spec file #137

Closed Olf0 closed 1 year ago

Olf0 commented 1 year ago

Continue with tasks from MR #133, comment #8:

Olf0 commented 1 year ago
  1. The first bullet point was addressed in commit f063d79.
  2. The second bullet point still needs to be evaluated before being applied to "production software" and was not yet part of this PR
  3. The third bullet point was addressed in commit f195a6c: Use defined macro for testing if a macro exists 0%{?sailfishos_version:1} would have been equivalent in this case, but defined as already present in SFOS 2.2.1 and presumably even much earlier.

    Useful references for RPM conditionals (there are many not useful ones):

  4. The remaining changes are better not applied, because it reduces build_yaml to being tested for existence instead of being set to 1, which is the proper test.