Closed Olf0 closed 1 year ago
The third bullet point was addressed in commit f195a6c:
Use defined macro for testing if a macro exists
0%{?sailfishos_version:1}
would have been equivalent in this case, but defined
as already present in SFOS 2.2.1 and presumably even much earlier.
Useful references for RPM conditionals (there are many not useful ones):
build_yaml
to being tested for existence instead of being set to 1, which is the proper test.
Continue with tasks from MR #133, comment #8:
BuildRequires: PackageKit-Qt5-devel
in line 27 →BuildRequires: pkgconfig(packagekitqt5)
%defattr(-,root,root,-)
→%if 0%{?sailfishos_version} && …
→%if %{defined sailfishos_version} && …
(and at other locations), see this message here for details.