sailfishos-chum / sailfishos-chum-gui

GUI application for utilising the SailfishOS:Chum community repository
https://openrepos.net/content/olf/sailfishoschum-gui-installer
MIT License
13 stars 17 forks source link

[Bug] Web-links hardly readable, because they are rendered in dark blue #186

Closed Olf0 closed 1 year ago

Olf0 commented 1 year ago

SailfishOS:Chum GUI application VERSION (\<Top pulley> → About): All 0.5.x and 0.6.0

BUG DESCRIPTION

Most web-links are hardly readable when using a dark launcher background, because they are rendered in dark blue on most pages. I observe this regularly on the page for a specific issue and on the page for a specific release. I believe I also saw this on other pages (they rarely contain embedded web-links), but the "About" page is fine; web-links there are rendered in turquoise, which is well visible on both dark and light backgrounds.

STEPS TO REPRODUCE

Look at pages for an individual issue or an individual release with embedded web-links, especially when the text of the links is long. Compare this to the rendering of web-links on the "About" page.

Suggestion

Let all QML pages render web-links in the turquoise colour they have on the "About" page.

Olf0 commented 1 year ago

Screenshots depicting this issue

Olf0 commented 1 year ago

Unfortunately above mentioned commits (as part of PRs #200, #201 and #202) did not resolve this issue.

nephros commented 1 year ago

From https://doc.qt.io/qt-5/qml-qtquick-text.html#linkColor-prop

This property works with the StyledText textFormat, but not with RichText. Link color in RichText can be specified by including CSS style tags in the text.

As the Label in IssuePage.qml uses RichText (because it displays a HTML page/snippet), the only way to influence link color is to inject the appropriate CSS either when creating the issue, or when updating the model.

nephros commented 1 year ago

Please see https://github.com/nephros/sailfishos-chum-gui/tree/fix-186 for a quick fix. I can make a PR if that is an acceptable change.

rinigus commented 1 year ago

If it works, it is fine by me :)

Olf0 commented 1 year ago

Excellent, thank you @nephros!

Edit: Is looking good in v0.6.3.