Add support for new release URL macro of SailfishOS 4.6

sailfishos-chum / sailfishos-chum-gui

GUI application for utilising the SailfishOS:Chum community repository

https://openrepos.net/content/olf/sailfishoschum-gui-installer

MIT License

13 stars 17 forks source link

Add support for new release URL macro of SailfishOS 4.6 #285

Closed rinigus closed 6 months ago

rinigus commented 6 months ago

Switches to new URL macro in SFOS >= 4.6. In longer term, allows to reduce the load on OBS and its administration
Reenable processing of the version string before adding it as CMake option. Without it, test builds will fail at OBS

Test build available at https://build.sailfishos.org/package/show/home:rinigus:tmp/sailfishos-chum-gui

Please check on SFOS 4.6.x.x as I don't have access to it. For that, use GUI build from 4.6 repo

Fixes: #270

rinigus commented 6 months ago

doesn't work yet, few more changes are needed

Olf0 commented 6 months ago

Please check on SFOS 4.6.x.x as I don't have access to it.

Neither do I.

Though I have two comments WRT the added code, see above.

piggz commented 6 months ago

I have installed this on a pinetab2 running 4.6.0.11, and after removing the override I had in place for the SFOS Version, the correct URL was used for the chum repository and packages are available in the UI

rinigus commented 6 months ago

@piggz, thanks!

rinigus commented 6 months ago

@Olf0, thank you very much for resolving the regex. ready to merge?

Olf0 commented 6 months ago

@Olf0, thank you very much for resolving the regex. ready to merge?

Yes, sure, please squash-merge. I will create a release then (already did a little preparation), and notify you by a push to sailfishos:chum when it successfully compiled at sailfishos:chum:testing.

rinigus commented 6 months ago

Thanks, merged