search

sailfishos-chum / sailfishos-chum-gui

GUI application for utilising the SailfishOS:Chum community repository
https://openrepos.net/content/olf/sailfishoschum-gui-installer
MIT License
13 stars 16 forks source link

Update notification doesn't include package name and version [Bug] #300

Open spodermenpls opened 1 week ago

spodermenpls commented 1 week ago

Sailfish OS VERSION: 4.6.0.13 and earlier
HARDWARE: Sony Xperia XA2
SailfishOS:Chum GUI application VERSION: 0.6.8-1 and earlier

BUG DESCRIPTION

According to the locale string %1 %2 updated, %1 is supposed to act as a placeholder for the package name and %2 as a placeholder for the package version, that get displayed in a notification popup after a successful package update. However, package name and version never get displayed on my end, and have never done so (at least to my recollection) in the past either, it only displays "updated", or in my German case "aktualisiert" (which was the original thing that made me pay attention, since if indeed intended as a single word, it should be spelled with a capital "A" in that scenario). The notifications after Install or Remove operations however do include package name and version, as intended.

STEPS TO REPRODUCE

If there's at least one update for a package available (unfortunately not that easy to re-create on demand..), execute it from the pulley menu and observe the notification pop-up banner after it is done.

ADDITIONAL INFORMATION

As mentioned in #167:

Affected strings in source TS file: https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/translations/sailfishos-chum-gui.ts#L39-L56

Corresponding code: https://github.com/sailfishos-chum/sailfishos-chum-gui/blob/main/qml/sailfishos-chum-gui.qml#L13-L30

[Please consider which other pieces of information may be relevant: Denote if this is not always reproducible, if this is a regression (then name to which older version), attach relevant data such as log files or the systemd journal, provide screenshots etc.]

Olf0 commented 1 week ago

Thank you very much @spodermenpls for this excellent bug report. I will take a closer look at the corresponding code, when I find some time for SailfishOS-related things (but not the next couple of days, unfortunately).