search

sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

Evaluate rpmlint results at obs #114

Closed Olf0 closed 2 years ago

Olf0 commented 2 years ago

Many of the warnings and "errors" the automatic rpmlint run at obs displays are indicating minor flaws and negligences. While some of these notices are simply wrong, erroneous or misleading and none is preventing Patchmanager from being built and run, most are worth being evaluated and considered.

See "rpmlint results" at https://build.sailfishos.org/package/show/home:b100dian:patchmanager/patchmanager For convenience / reference the results for Patchmanager 3.1.0 are attached here:

nephros commented 2 years ago

Some of these I try to address in https://github.com/nephros/patchmanager/tree/rpmlint

nephros commented 2 years ago

So I have played around with several variants of rpmlintrc, and it seems impossible to silence most of the silly complaints on OBS.
ALL packages there get these though (e.g. "weird" permissions for sources).

So I'll pick a couple of trivial things from my tests which actually improve things, but for most cases, these lining results must be ignored and can not be switched off.

Olf0 commented 2 years ago

So I have played around with several variants of rpmlintrc, and it seems impossible to silence most of the silly complaints on OBS.

That is fine, it is rpmlint! :wink:

ALL packages there get these though (e.g. "weird" permissions for sources).

It is overly picky and sometimes just wrong.

So I'll pick a couple of trivial things from my tests which actually improve things, but for most cases, these lining results must be ignored and can not be switched off.

Exactly: Take the complaints by rpmlint as hints and only address the ones, which "actually improve things".