Closed Olf0 closed 2 years ago
Sorry @CODeRUS, I missed to test this, when I had Patchmanager-2.4.0-10.42.1 installed for re-evaluating issue #21 in October. Consequently I also did not reply. I am planning to retest with Patchmanager 3 in the next couple if weeks (as you branched off in November, i.e. after commit cb031a00b), after installing and configuring SFOS on Xperia X (supposing that goes smoothly).
Nice to see you still there :)
Retested with Patchmanager 3.0.36 (beta) under SFOS 2.2.0 on an Xperia X. I think the behaviour has changed slightly (compared to Patchmanager 2 under SFOS 2.1.4 on a Jolla 1): After "Restart preloaded services", the "Accept / Restart services" dialogue is displayed; when hitting "Restart services" the Jolla Settings seem to crash and the view switches to the home screen (with the Settings app being cover-less).
Any suggestions what else to check (e.g, would it be helpful to try Patchmanager 3 under SFOS 2.1.4 on a Jolla 1?) or how to take logs, which may support you in debugging this?
probably you applied patch modifying settings? so settings was killed for patch being properly working :)
btw you can join telegram group for testing fresh stuff before it will be released: https://t.me/joinchat/CaLQAk2RBc--WXbv5rHx1A
probably you applied patch modifying settings? so settings was killed for patch being properly working :)
Mmmh, I don't fully understand. Well, for PM2 (under SFOS 2.1.4 on my Jolla 1), I don't really care anymore (but may check next week, if my impression was right, that the behaviour was slightly different compared to PM3-beta under SFOS 2.2.0). As you committed a code change WRT this issue, I expected some behavioural change in consequence.
For PM3 the answer is "No" (even though I don't fully understood your statement), as I did:
Thus there were just a few, well known Patches applied.
Anyway, main point is: This still fails to work with PM3 under SFOS 2.2.0 in a freshly and cleanly installed environment.
I mean if patch in Settings category restarting preloaded services will kill settings applicaiton for sure
O.K. So I did:
After testing more than 5 Patches this way, three outcomes are observed:
BTW, wow, the log for each Patch applied is cool and useful. I currently have two issues with it:
Unreversed patch detected! Ignore -R [n]
(What does the " -R" mean, I would have rather expected a "?".)
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
(Nitpicking: Full stop "." is missing after "ignored".)
But subsequently the sections Dry running patch, Applying text patch and Creating backup patch do succeed!?!
I had no Patches installed when installing Patchmanager 3.0.36 (as that was carried out on a freshly installed SailfishOS) and unapplied all Patches before updating to Patchmanager 3.0.51 (see above).I am pretty sure single click on patch log should copy it's contents to clipboard.
And the text of the log is the output of patch utilities. When applying it is checking if patch already applied by dry-running unapply sequence, which is done by -R parameter.
Behaviour unchanged with PM 3.0.53 (compared to 3.0.51) for all three categories ("Nothing happens", "Settings app 'crashes'", "UI is restarted", as described above) and "copy log to clipboard" function. Sorry, I would have been happy to report something more positive.
Re-tested with PM 3.0.57: The behaviour of "Restart preloaded services" seems to be O.K..
I think I have understood now, that PM3 is doing the right thing technically: Only restart, what really needs to be restarted after applying a single or multiple Patches. Which can be either: (a) nothing (b) the Settings app (c) the whole SFOS-GUI (Lipstick) PM 3.0.57 also seems to always correctly pick the "strongest" measure of these, when multiple Patches have been applied. (Probably earlier PM3 versions already handled this properly, I was just too blind to see.)
Thus the only remaining complaints are about the lack of feedback to the user:
"Restart preloaded services" does not work anymore with Patchmanager 2.3.3-10.41.1 under SailfishOS 2.1.1.26: When triggered, it simply does nothing! This function (in the pulley menu, after a Patch has been applied or unapplied) was working well with Patchmanager 2.3.1-10.39.1 under SFOS 2.1.0.11 Restarting the "Homescreen" by other means (e.g. Patch: Enhanced Power Menu or Patch: Quick settings on power menu) works under SailfishOS 2.1.1.26