sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

Tapping the remorse timer should cancel activating patches only temporarily (for that single boot), not DISABLE all patches permanently #321

Open wetab73 opened 2 years ago

wetab73 commented 2 years ago

If one turns off the option to "Activate patches when booting", a remorse timer is shown upon boot and tapping it allows cancelling activation of enabled patches. So far so good.

The problem is that instead of temporarily cancelling activation of patches (on that specific boot only), after tapping that remorse timer Patchmanager DISABLES all patches FOR GOOD. All patches get PERMANENTLY DISABLED and nothing gets started upon the next reboot (even though the remorse timer is again shown to allegedly stop activating patches). It takes manually re-enabling all patches from scratch.

Tapping the remorse timer should cancel activation of patches only temporarily (i.e. for that boot only). Upon the next reboot, Patchmanager should activate them again, unless the remorse timer is tapped again to prevent it.

nephros commented 2 years ago

Currently PM only knows two states of patches that are stored persistently: activated and deactivated.

When the startup UI runs, it then can either apply the stored settings (activate all enabled patches), or not do that, which causes all to be not activated.

This feature would require a third state, enabled-but-not-activated to be set by the startup UI and interpreted by the daemon.

Maybe #277 and #302 can improve the situation after tapping cancel when they have been finalized.