search

sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

Add three new Testcases: Version Checks #430

Closed nephros closed 1 year ago

nephros commented 1 year ago

These allow playing around with version check strictness.

b100dian commented 1 year ago

Thanks for the direct pings @Olf0 . You guys are doing a great thing with this project and I sometimes have the impression everything is so smooth I don't need to do a thing ;) Glad I can still help here and there though!

@nephros Please remind me, how does the test app test the negative "PM should not allow to activate or install it" ? Thanks!

nephros commented 1 year ago

The new ones at the moment do not show up in the test app at all.

They just have weird versions in the metadata so allow testing (future) relaxed compat checks.

I probably should add something to the app as well, that's right.

Olf0 commented 1 year ago

I probably should add something to the app as well, that's right.

@nephros, are you planning to do that in this PR or in a new one?

Depending on your reply I would (suggest to) ping Vlad once again, either now or when the test app was expanded.

nephros commented 1 year ago

Not planned at the moment.

For me, as-is is good enough to test the logic in PM, having a Test App effect is not really needed and might convolute the test case.

Olf0 commented 1 year ago

@b100dian: Please see the two prior messages.

Olf0 commented 1 year ago

You guys are doing a great thing with this project and I sometimes have the impression everything is so smooth I don't need to do a thing ;)

BTW,

Personally I will try to finish a couple of open tasks in the next months, before seriously considering to try new [non-SailfishOS] things.

I.e., I will slowly wind down my SFOS-related activities. Long story with background info is linked to by the quote above.

b100dian commented 1 year ago

You guys are doing a great thing with this project and I sometimes have the impression everything is so smooth I don't need to do a thing ;)

BTW,

Personally I will try to finish a couple of open tasks in the next months, before seriously considering to try new [non-SailfishOS] things.

I.e., I will slowly wind down my SFOS-related activities. Long story with background info is linked to by the quote above.

That was quite a story, thanks!

Made me think harder on the subject.