search

sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

[Bug] in functions install and remove the patch success prevent to make the patch backup #446

Open robang74 opened 1 year ago

robang74 commented 1 year ago

SailFish OS version: 4.5.0.9 Patchmanger Version: 3.2.9 Hardware: Xperia 10 II

BUG DESCRIPTION

In these two functions remove_text_patch() and install_text_patch() the exit 0 in success() prevents that the backup of the installed/removed patch can be managed correctly.

STEPS TO REPRODUCE

It is in the code - it is about the flow logic.

ADDITIONAL INFORMATION

Please check this commit:

The code is different because it refers the unified version of pm_apply and pm_unapply but it is the logic that matters.

CODeRUS commented 1 year ago

Please take care to fix the code issues reported by this person, but create your own changes. no commits authored by this person are allowed to be merged in this repo.

CODeRUS commented 1 year ago

@nephros @nephros @Olf0 fyi

Olf0 commented 1 year ago

@b100dian was missed.

Olf0 commented 1 year ago

Please let us carry out this meta-discussion at the oldest bug report filed by robang74: #444

Every thing discussed there an the meta-level is sure applicable to the filed issues #445 and #446, too (plus any future ones by robang74).