search

sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

[src/qml/RestartServicesDialog.qml] Remove line duplicated by PR #459 #463

Closed Olf0 closed 5 months ago

Olf0 commented 5 months ago

See line 95 and https://github.com/sailfishos-patches/patchmanager/pull/459/files/f38f25bdc1c9ece8004051fb557d751c212d38db#diff-afc5c5bd5b81cf0d933a1714b2b351ee6f521f116ebec886d5bfb5e8fdc03d20R100

Olf0 commented 5 months ago

Well spotted, LGTM.

Well, I tried to get heard three times: February 2024, March 2024 and April 2024.

But I know one has to look closely in GitHub's web-frontend to spot pending reviews. A counter-measure is to switch on Settings→Branches→"Require conversation resolution before merging". But that introduces another strict rule, which I do not like generally; OTOH any maintainer can click on the "Resolve conversation" button, so this measure would never really prevent one to merge an approved PR. Opinions (@nephros & @b100dian)?