sailfishos-patches / patchmanager

Patchmanager for SailfishOS
https://openrepos.net/content/patchmanager/patchmanager
Other
21 stars 22 forks source link

Clicking on a patch with no main.qml should show info page #54

Closed b100dian closed 3 years ago

b100dian commented 3 years ago

As reported https://forum.sailfishos.org/t/patchmanager-patches-in-koli-4-0-1/4925/143

nephros commented 3 years ago

Should be fixed in cb01a77.

b100dian commented 3 years ago

Closing, @hsjpekka There's a build[1] in chum:testing if you want to test it out, feel free to re-open this bug if it doesn't work for you. Thanks!

https://build.sailfishos.org/package/show/sailfishos:chum:testing/patchmanager

Olf0 commented 3 years ago

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Here is the corresponding line in PM3 for the commit resolving this issue.

Just wondering, if this change for PM2 is also useful for PM3, but lack the understanding to determine & decide that.

nephros commented 3 years ago

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Yep, seems likely, that is just a very minor cleanup of code duplication that was introduced in cb01a77

Olf0 commented 3 years ago

Is this altered line in a commit by elros34 for "PM2-forever" related to this?

Yep, seems likely, that is just a very minor cleanup of code duplication that was introduced in cb01a77

Thanks for looking up, when and by whom this line was introduced.

But so I suppose it makes sense to introduce that cleanup also here at PM3, correct?

nephros commented 3 years ago

But so I suppose it makes sense to introduce that cleanup also here at PM3, correct?

I have it in a "trivial fixups" branch - i'll put it in one of my next PRs that seems appropriate.