sailfishos / nemo-qml-plugin-calendar

BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Add a test on CalendarEvent modification signals and use uid/recid for sendResponse manager API. #32

Closed dcaliste closed 2 years ago

dcaliste commented 2 years ago

The two commits from #30 that looks already good to go in.

I agree that the event->incidence commit in not very useful by itself since it would prepare to load todos and journals but this will not happen without moving to KCalendarCore storage in the manager. The same for the one replacing CalendarData::EmailContact with its KCalendarCore equivalent.

Besides, about your point that you tried to avoid KCalendarCore structures from the UI thread, I may add that they have move upstream away from ::Ptr for many small structures, like attendees, persons… So They can now be used in the UI thread without risk and would avoid code duplication.