search

sailfishos / nemo-qml-plugin-calendar

BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

[nemo-qml-plugin-calendar] Clone existing parent when saving an excep… #61

Closed dcaliste closed 7 months ago

dcaliste commented 1 year ago

…tion.

When moving the dissociation code out of the save function, it had the drawback that only properties copied in the CalendarData::Event structure are preserved in the exception.

This may creates some issues with the sync plugins that may use properties that are not part of CalendarData::Event structure.

Ensure that such properties are kept when creating an exception by cloning the parent before updating it with the exception modifications.

@pvuorela, this is correcting an issue introduced in 4e0b556a, when moving the dissociation code out of the save routine. This move simplified the creation of a CalendarEventModification but had the drawback that some properties of the parent (those not duplicated in the CalendarData::Event structure) were lost in the process. This PR should solve this. It would also make sailfishos/buteo-sync-plugin-caldav#20 obsolete.

dcaliste commented 8 months ago

Going back to my calendar modifications, @pvuorela, may you have a look on this PR when you have the time to, please ? Thank you in advance.

pvuorela commented 8 months ago

Acknowledging the request :) Having now a bit of queue of things, but I'll get into this.

dcaliste commented 8 months ago

Thanks, no problem. No hurry.