search

sailfishos / sailfish-browser

Sailfish Browser
https://github.com/sailfishos/sailfish-browser/wiki/Sailfish-Browser-wiki
Mozilla Public License 2.0
305 stars 86 forks source link

Restore WebRTC code to ESR 91 #1024

Closed llewelld closed 1 month ago

llewelld commented 10 months ago

In order to get ESR 91 to build it was necessary to disable WebRTC. See 577ff63ae39d49c83bab7fca86f2e1d32053d167.

Instead of doing this we should reapply the WebRTC patches. Some of these require the WebRTC build files to be regenerated. See https://firefox-source-docs.mozilla.org/build/buildsystem/gn.html and the following patches:

0077-sailfishos-webrtc-Adapt-build-configuration-for-Sail.patch
0078-sailfishos-webrtc-Regenerate-moz.build-files.-JB-537.patch
0079-sailfishos-webrtc-Disable-desktop-sharing-feature-on.patch
0080-sailfishos-webrtc-Enable-GMP-for-encoding-decoding.-.patch
0081-sailfishos-webrtc-Implement-video-capture-module.-JB.patch
llewelld commented 1 month ago

These are now included in the sailfishos-esr91 branch:

36cb2567f3c2 [sailfishos][webrtc] Implement video capture module. JB#53982
ffc93a057267 [sailfishos][webrtc] Implement video capture module. JB#53982
2e65e420780a Enable GMP for encoding/decoding. JB#53982
9a481753fd3b Regenerate moz.build files.
c1b06c57549c Switch vp8_encoder_simulcast_proxy for encoder_simulcast_proxy
534ffad75341 Disable desktop sharing feature on SFOS. JB#53756
7bda060a012f [sailfishos][webrtc] Regenerate moz.build files. JB#53756
71ea0764f5ef [sailfishos][webrtc] Update GN build files for WebRTC. JB#53756

There are more patches than there were previously, partly because the changes to the build process have been split into separate patches for the manual and autogenerated parts (as seems to be the approach preferred upstream) and partly due to other changes upstream which affected WebRTC and which have been rolled in.

Given that WebRTC is now working after applying these patches and that #1064 is logged separately, I'll close this as completed.