search

sailfishos / sailfish-browser

Sailfish Browser
https://github.com/sailfishos/sailfish-browser/wiki/Sailfish-Browser-wiki
Mozilla Public License 2.0
305 stars 86 forks source link

Fix Qt printing pipeline for ESR 91 #1030

Closed llewelld closed 7 months ago

llewelld commented 10 months ago

The Qt-related printer code has changed and printing to PDF is now broken. This needs to be fixed.

The following changes were needed to get ESR 91 to build and affected printing, so may very well be the cause of the problem:

  1. e31ed7aaa670a4541ed4ab467716e16fa61342a7.
  2. 52f8c2eb9c7072245f0d35b85589f10ffc1fc045.
  3. ff3f6467a7717fdd782952bcfd17d7ba3d205df9.
llewelld commented 7 months ago

With the latest changes the PDF printing pipeline is now working correctly. The following changes were needed to get it back up and running:

https://github.com/llewelld/gecko-dev/commit/729aafe3d80424062b00da99d59567d2e26d6b14 https://github.com/llewelld/sailfish-browser/commit/e2b97dadf035ee3d94dd35264b2694934b858ef3 https://github.com/llewelld/qtmozembed/commit/28f1d3407cbb77c78d411b8c6376e6addfbec75b https://github.com/llewelld/embedlite-components/commit/c97c3a5fcd3ac9bf30b9d5995221c77c49a344b6

Issue #1054 is a leftover from this task that needs to be implemented.