search

sailfishos / sailfish-browser

Sailfish Browser
https://github.com/sailfishos/sailfish-browser/wiki/Sailfish-Browser-wiki
Mozilla Public License 2.0
305 stars 86 forks source link

Fix JavaScript errors from EmbedLiteChromeManager.js #1041

Closed rainemak closed 8 months ago

rainemak commented 9 months ago

Fix JavaScript errors from EmbedLiteChromeManager.js.

JavaScript error: file:///usr/lib64/mozembedlite/components/EmbedLiteChromeManager.js, line 213: NS_ERROR_FILE_NOT_FOUND:

llewelld commented 8 months ago

Upstream changes mean the AboutCertViewerHandler service is now an actor-based RPM comprised of AboutCertViewerChild.jsm and AboutCertViewerParent.jsm to replace the previous AboutCertViewerHandler.jsm.

As a result of this it apparently doesn't require either init() or uninit() to be called (they've both been removed). See Bug 1646197 and the related changeset D80017.

I couldn't see anywhere else in the EmbedLite code where the service is used, so hopefully any other changes needed will already be part of the upstream gecko-dev changes.

As a result I've reverted embedlite-components commit b1510a7a which looks to be no longer necessary.

See commit b3a105be.