Open llewelld opened 7 months ago
The changes to the offscreen rendering mean that this works correctly again, so I've reverted it with commit cfb68c46e9779dd25f8515078cd0b1587faf47bf.
I tested a few sites and checked their covers were rendered correctly, including sites that rendered WebGL content.
Closing this was a mistake; it still needs fixing :(
The call to
window.setBrowserCover(webView.tabModel)
inBrowserPage.qml
causes the user interface to hang. To reproduce:The same result can also be had by selecting "New private tab" from the main browser menu.
Commit 8a8c474abed7d95ac comments out the call to prevent this from happening, but a real fix is needed because this also has the side effect of preventing the cover image from rendering correctly.
The hang doesn't cause a crash, but it does cause a new EGL/Wayland thread to be created which could possible be the cause of the hang, see thread 70 below:
Here's the backtrace for the tread:
Note that this is a hang not a crash, so this backtrace is the rest of interrupting the program running.