Closed llewelld closed 1 month ago
The crash was happening in the Hyphenator, third-party Rust component. As in the backtrace, the crash happens with the pub fn find_hyphen_values(&self, word: &str, values: &mut [u8]) -> isize
method. If the output values
buffer is smaller than the input word
string slice, an assert
in the code causes the method to panic, bringing down the browser.
Commit https://github.com/llewelld/gecko-dev-mirror/commit/b67d3cf6a2d39cc7ea48821c23dcb9049e150a20 converts the assert
into an early return in case the condition doesn't hold.
This seems to fix the crash. There's likely a deeper underlying issue that explains why this is happening (especially why it's an issue on Sailfish OS but not in other contexts) and this should probably be looked into. But I'm hoping this will do for the time being so will close this issue.
When visiting certain pages on amazon.de with ESR 91 the browser crashes consistently.
For example the following page (randomly selected from the main page) crashes:
https://www.amazon.de/-/en/Sony-MDR-ZX110-Foldable-Over-Headphones-black/dp/B00NBR70DO/ref=sr_1_5?crid=314A2VKSVMHSR&keywords=Headphones&qid=1704580609&sprefix=headphones%2Caps%2C208&sr=8-5
A similar page on amazon.co.uk didn't crash, although it's not clear whether this is because it's a different site or a different page:
https://www.amazon.co.uk/Sony-MDRZX110B-AE-Headphones-Black/dp/B00NBR70DO/ref=sr_1_3?keywords=Sony+mdr-zx110&qid=1704581464&sr=8-3
Here's the backtrace for this crash: