search

sailfishos / sailfish-components-webview

Mozilla Public License 2.0
13 stars 23 forks source link

Compiler failure: marked ‘override’, but does not override #173

Open kan-ibal opened 3 weeks ago

kan-ibal commented 3 weeks ago

SDK 3.11.1 target 4.6.0.13

../../../sailfish-components-webview-1.6.0/import/webview/rawwebview.cpp:40:13: error: ‘quint32 SailfishOS::WebView::ViewCreator::createView(const quint32&, const uintptr_t&, bool)’ marked ‘override’, but does not override
   40 |     quint32 createView(const quint32 &parentId, const uintptr_t &parentBrowsingContext, const bool hidden = false) override;
      |             ^~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make[2]: *** [Makefile:452: rawwebview.o] Error 1
mlehtima commented 3 weeks ago

Versions 1.6.0 and above need gecko ESR91 from https://github.com/sailfishos/gecko-dev/ (latest master branch) which is not in 4.6.0 target but will be in 5.0.0.