[sailfish-office] Open csv files as spreadsheet documents. Fixes JB#4…

[mphilippov-omp]

…6745

[pvuorela]

Tried downloading couple test files from https://people.sc.fsu.edu/~jburkardt/data/csv/csv.html

...both crashed. How much have you tested these?

[mphilippov-omp]

Well, I know it. That's why our first decision was to open CSV files as plain text documents.

I also know you are solving the problem of XLS files. Opening XLS files also crashes application. They both open with Spreadsheet and the mistake is in the same place, so solving your problem will automatically solve mine

---

От: Pekka Vuorela [notifications@github.com] Отправлено: 26 августа 2019 г. 13:13 Кому: sailfishos/sailfish-office Копия: Mikhail Filippov; Author Тема: Re: [sailfishos/sailfish-office] [sailfish-office] Open csv files as spreadsheet documents. Fixes JB#4… (#136)

Tried downloading couple test files from https://people.sc.fsu.edu/~jburkardt/data/csv/csv.html

...both crashed. How much have you tested these?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sailfishos/sailfish-office/pull/136?email_source=notifications&email_token=AM5ECXT46E42TNRKTCWNOXDQGOUGDA5CNFSM4IPAXT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5D6GTA#issuecomment-524804940, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM5ECXQ54QA73O4YNTVIYPTQGOUGDANCNFSM4IPAXT2A.

[dcaliste]

Opening XLS files also crashes application.

This MR in Calligra should correct the problem…

[mphilippov-omp]

I know it, thats why I renamed commit messages from Fixes to Contributes. Thank you, I'll try it

---

От: Damien Caliste [notifications@github.com] Отправлено: 28 августа 2019 г. 11:57 Кому: sailfishos/sailfish-office Копия: Mikhail Filippov; Author Тема: Re: [sailfishos/sailfish-office] [sailfish-office] Open csv files as spreadsheet documents. Fixes JB#4… (#136)

Opening XLS files also crashes application.

This MR in Calligrahttps://git.sailfishos.org/mer-core/calligra/merge_requests/11 should correct the problem…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sailfishos/sailfish-office/pull/136?email_source=notifications&email_token=AM5ECXV7CYUPAZ7RXP4B3KDQGY4ZHA5CNFSM4IPAXT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KMW6Y#issuecomment-525650811, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM5ECXTYUVAC4OWT5HLS3STQGY4ZHANCNFSM4IPAXT2A.

[pvuorela]

Now it doesn't crash, but opens qwidget based import dialog on a separate window, and then choosing something open another qwidget based error dialog and finally crashes. We shouldn't have any QWidget UI shown.

[mphilippov-omp]

Yes, I tried it. I haven't seen any error dialogs, just crashing. But when I launch sailfish-office application second time, previosly opened CSV file is displayed

---

От: Pekka Vuorela [notifications@github.com] Отправлено: 3 сентября 2019 г. 10:28 Кому: sailfishos/sailfish-office Копия: Mikhail Filippov; Author Тема: Re: [sailfishos/sailfish-office] [sailfish-office] Open csv files as spreadsheet documents. Fixes JB#4… (#136)

Now it doesn't crash, but opens qwidget based import dialog on a separate window, and then choosing something open another qwidget based error dialog and finally crashes. We shouldn't have any QWidget UI shown.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sailfishos/sailfish-office/pull/136?email_source=notifications&email_token=AM5ECXR42RQAOEP7FBO2OXTQHYG3JA5CNFSM4IPAXT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XJCLA#issuecomment-527339820, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM5ECXXVFTVJ47KABKMRTULQHYG3JANCNFSM4IPAXT2A.

[pvuorela]

Obsoleted.