sailfishos / sailjail-permissions

Other
5 stars 17 forks source link

Call recorder permissions for Phone #52

Closed b100dian closed 3 years ago

b100dian commented 3 years ago

It seems the call recording function cannot store the audio files. This is my attempt to give the phone app the required permissions.

Not sure if this should go into Phone.permissions or voicecall-ui though

b100dian commented 3 years ago

@abranson I know you recently modified the hosts file access permissions, can you also take a look at this?

pvuorela commented 3 years ago

This already in: https://github.com/sailfishos/sailjail-permissions/pull/49

b100dian commented 3 years ago

Thanks @pvuorela, it is not clear to me how the CallRecordings permission is linked to the voicecall-ui or Phone permissions (and if the CallRecordings folder is automatically created). Is there any other commit linking the above? Or the question is more: how can I update the rules from this whole repo on my device, I just build the rpm and upon installing it refreshes the current 4.0.1 settings?

pvuorela commented 3 years ago

There was also a change in the voicecall app side for requiting the new CallRecordings permission. If you compile an rpm from this repository you can then manually edit the .desktop file for the new permission. Or atlernatively use this locally if you need it working. Will be fixed in the next release anyway.

b100dian commented 3 years ago

Thanks @pvuorela, I think I'll wait for the next release and go ahead with my patch for now, but am glad this has been already worked on. I think you can close this now.