search

sailoog / openplotter

Obsolete project. New one and active: https://github.com/openplotter
http://www.sailoog.com/openplotter
GNU General Public License v2.0
153 stars 53 forks source link

backwards compatibility and fix #136

Closed e-sailing closed 7 years ago

e-sailing commented 7 years ago

added 4 decimal for nmea 0183 generator add offline Help

dmdelorme commented 7 years ago

You might want to go a few more decimal places as i have found openCPN 4.5.0 Barometer needs to be in the value range of 1.1 to .8 or so for all the gages to work. MPO is that OCPN Gages shoud decode NMEA sentences Different

I went back to find the code for my decision several hours later.. // XDR Pressure if (m_NMEA0183.Xdr.TransducerInfo[i].TransducerType == _T("P")) { if (m_NMEA0183.Xdr.TransducerInfo[i].UnitOfMeasurement == _T("B")) { xdrdata *= 1000; SendSentenceToAllInstruments(OCPN_DBP_STC_MDA, xdrdata , _T("mBar") ); The Docs State barometric | "P" pressure | 0.8..1.1 or 800..1100 | "B" bar | "Barometer" But as you can see from the code this is not correct pressure has to be 0.8 and 1.1

e-sailing commented 7 years ago

I saw your branch after I edited the python script. In the forum they wanted 4 decimal places. If you have a Barometer on NMEA2000 you only have 3 decimal places. Do you really need 6? btw: In the past there was an error in signalk converting nmea2000 to propulsion..revolution (they used rpm instead of Hz; Hz is SI-unit) when they changed it I had to multiply propulsion..revolution * 60.

dmdelorme commented 7 years ago

It is a rounding issue as the Sk value is in Pa "102954.000 Opencpn Wants Bar so i divide by 100000

and get 1.029040 round 6 1029.040
1.0290 round 4 1029.000 1.03 round 2 1030.000 then OpenCPN *1000

I would prefer if OpenCPN just read SK as we are just doing a lot of extra stuff or Ditch the gauges and use freeboard. I am fine with 4 I was just being a geek I did not see the Forum posts and made the change for my self.

dmdelorme commented 7 years ago

I will try this new code as i have couple of pi3 set up for testing

dmdelorme commented 7 years ago

looks good freeboard is acting up but it might be my flow