Adding auto-converted VS Code theme

sailorhg / fairyfloss

fairy floss text editor theme

http://sailorhg.github.io/fairyfloss

300 stars 45 forks source link

Adding auto-converted VS Code theme #4

Open bnookala opened 8 years ago

bnookala commented 8 years ago

So… since I've been working a lot on VS Code, I figured it wouldn't be too much of a hassle to convert your theme to work with it! As far as installation and distribution goes, I packaged the 0.1.0 version using the VS Code publishing tool as a preliminary means of installation. The instructions are in index.html, but it's as simple as dragging the downloaded package onto the editor.

As far as marketplace distribution goes (so users can install it through the VS Code itself), I didn't feel too comfortable doing that, but here are the instructions on how to have it appear in the marketplace.

Thanks! Bhargav

juri commented 8 years ago

I've been playing with this a bit. Two observations:

I don't think the .vsix file is necessary for VS Code?
It looks to me like it's really difficult to make a well-functioning version of this to VS Code, due to the limitations of the ui theming (at least as of VS Code 1.2.) You've specified vs-dark as the UI theme, but that has the result that line numbers are effectively invisible. If you specify vs, for the light theme, you won't be able to make out text in the search box.

bnookala commented 8 years ago

@juri Thanks for your observations!

The .vsix file is an artifact of compilation from the vsce tool, and packages the theme in a portable file that VS Code can open and immediately 'know' what to do with: https://code.visualstudio.com/docs/extensions/install-extension. It's just a convenient distribution method if you don't have an extension in the marketplace
Yeah, I definitely agree here. I can bring that up with the VS code team the next time I talk with them :)