fix: return early from Page:render if no filename

[luisbg]

If filename is nil there is no use for setting the src, we should return early.

[luisbg]

I can add that error printing when the controller is missing if you tell me how/where you want it printed :smile:

[Etiene]

Yea, I think it's best to add already some kind of error message :) An error("Your message") should do :)

[luisbg]

Nice! error() shows a page using the default template showing the error and stack trace. Neat.

[Etiene]

What's missing in this case is not the controller, but the view file. Maybe this would be better? error("Could not find view file: "..dir.."/"..filename)

[luisbg]

You are right. That gives a more verbose error.

Fixing it now.

[Etiene]

Oh wait! Guess we both weren't paying attention. If filename is nil, it won't concatenate x) This is not about not finding the view file, but when a view name is not passed... sorry... Maybe error("No view name available.") or error("A view name is required.") ?

[luisbg]

LOL! Right, if filename is nil it won't help in the concatenation.

[Etiene]

but it filename name is nil there is no filename to concatenate with the error message :)

[luisbg]

ooops, you replied when I was editing.

I realized this just after my last comment. Gulps (shame)

[Etiene]

don't worry, I made the same mistake xD

[luisbg]

Thanks Etiene! Enjoy your Friday night :beers: