Improve Nginx support - Githubissues

sailorproject / sailor

A Lua MVC Web Framework.

MIT License

924 stars 124 forks source link

Improve Nginx support #111

Closed m1cr0man closed 8 years ago

m1cr0man commented 8 years ago

Connects to #72 Connects to #48 Fixes #42

The new friendly URLs code didn't work at all, so I rewrote it. It now takes into account the settings defined in conf.lua, and also removes the other dependencies.

Also, the wrong sailor.path was being selected out of r.filename due to the use of .- instead of .*. A nice consequence of this change is that you don't need to know what the r.uri is, and so it has been removed from the expression.

Etiene commented 8 years ago

Hey! Sorry for the long time it took me to review this. Unfortunately I can't merge this pull request because the friendly urls are not working! (At least not for me) I think we need some automated tests for this!

The problem was on my end! Merging :) I still think we need some automated tests for this though!

Etiene commented 8 years ago

Thanks for the awesome PR 👯